BG96 operator name and access technology (IDFGH-3844) #5750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
AshUK
changed the title
AshUK
commented
Aug 18, 2020
examples/protocols/pppos_client/components/modem/include/esp_modem_dce.h
Outdated
Show resolved
Hide resolved
|
Thanks for your contribution. |
| @@ -193,9 +193,9 @@ static esp_err_t bg96_handle_cops(modem_dce_t *dce, const char *line) | |||
| size_t len = strlen(line); | |||
| char *line_copy = malloc(len + 1); | |||
| strcpy(line_copy, line); | |||
| /* +COPS: <mode>[, <format>[, <oper>]] */ | |||
| /* +COPS: <mode>[, <format>[, <oper>][, <Act>]] */ | |||
There was a problem hiding this comment.
nitpick
/* +COPS: <mode>[, <format>[, <oper>[, <Act>]]] */
| @@ -210,6 +210,11 @@ static esp_err_t bg96_handle_cops(modem_dce_t *dce, const char *line) | |||
| err = ESP_OK; | |||
| } | |||
| } | |||
| if (i >= 4) { | |||
| char act_str[3] = {0}; | |||
| int len = snprintf(act_str, 3, "%s", p[3]); | |||
There was a problem hiding this comment.
nitpick: This will produce defined but not used warning. Do we want to check if the len is correct?
| @@ -467,8 +474,6 @@ modem_dce_t *bg96_init(modem_dte_t *dte) | |||
| DCE_CHECK(bg96_get_imei_number(bg96_dce) == ESP_OK, "get imei failed", err_io); | |||
| /* Get IMSI number */ | |||
| DCE_CHECK(bg96_get_imsi_number(bg96_dce) == ESP_OK, "get imsi failed", err_io); | |||
| /* Get operator name */ | |||
| DCE_CHECK(bg96_get_operator_name(bg96_dce) == ESP_OK, "get operator name failed", err_io); | |||
There was a problem hiding this comment.
Removing get_operator_name() from init might cause an inconsistency in idf examples. I would suggest adding
ESP_ERROR_CHECK(dce->get_operator_name(dce));
to the pppos_client_main.c after the specific initialization section.
This may require applying the same changes to other devices (SIM800, ..) as well
espressif-bot
pushed a commit
that referenced
this pull request
Jan 15, 2021
Merges #5750 Signed-off-by: Liu Han <[email protected]>
|
Closing this as it has been now been added to v4.3-beta1, thank you to those that contributed. |
espressif-bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
Merges #5750 Signed-off-by: Liu Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
Adds get operator functionality for BG96, currently the COPS command is only called at initialisation, if the modem does not yet have at network connection the operator name will be empty. Calling get operator will update the operator name value.
Adds the access technology used by the modem, this is required when the application logic is dependent on the access technology used e.g. NB IoT applications need to send messages via COAP and 2G uses MQTT.
Fixes a stack smashing issue on BG96