Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release/v4.0 sntp logic to release/v3.3 (IDFGH-1902) #4103

Conversation

erki1993
Copy link

Hello!

esp-idf version release/v4.0 has additional SNTP logic that could also be ported to release/v3.3.

The functionality we would like to get on v3.3 is sntp_set_time_sync_notification_cb as otherwise there is no way to detect when system time is updated.

Regards,
Erki

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Erki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title add release/v4.0 sntp logic to release/v3.3 add release/v4.0 sntp logic to release/v3.3 (IDFGH-1902) Sep 20, 2019
@KonstantinKondrashov
Copy link
Collaborator

Hi erki1993!
Thank you for your interest in this. I'll do backport on 3.3. Thank you.

@KonstantinKondrashov
Copy link
Collaborator

Hi @erki1993!
I have created an MR into our internal repository it will be merged ASAP. Thanks.

@erki1993
Copy link
Author

erki1993 commented Oct 1, 2019

Hi @KonstantinKondrashov any news on the merge?

igrr pushed a commit that referenced this pull request Oct 18, 2019
@Alvin1Zhang
Copy link
Collaborator

@erki1993 Thanks for contribution, please refer to 07a3eca. Thanks.

0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this pull request May 5, 2021
…as part of WiFi.begin(). (espressif#4103)

Fixing DHCP client stop if WiFi.config() is called before WiFi.begin() (as done in WiFiClientStaticIP.ino)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants