esp_http_client: separate buffer_size config option for transmit (IDFGH-1226) #3528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
buffer_size_tx
toesp_http_client_config_t
.It's important to have different buffer sizes when you need to download large files. To do so, you need RX buffer to be as big as you can afford. But you don't want to waste memory on TX buffer in this case.
For example. I want 8K RX buffer (all I can afford). With single
buffer_size
this will allocate another 8K for TX buffer which I don't need. For TX buffer 2K is more than enough. 6K wasted. I'd rather allocate 14K for RX buffer in this case.Original issue #3285
Even if this PR will be rejected I really hope you'll implement this functionality b/c it's crucial for my project.
Thanks.