Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_http_client: separate buffer_size config option for transmit (IDFGH-1226) #3528

Closed
wants to merge 1 commit into from

Conversation

olegantonyan
Copy link
Contributor

This PR adds buffer_size_tx to esp_http_client_config_t.
It's important to have different buffer sizes when you need to download large files. To do so, you need RX buffer to be as big as you can afford. But you don't want to waste memory on TX buffer in this case.

For example. I want 8K RX buffer (all I can afford). With single buffer_size this will allocate another 8K for TX buffer which I don't need. For TX buffer 2K is more than enough. 6K wasted. I'd rather allocate 14K for RX buffer in this case.

Original issue #3285

Even if this PR will be rejected I really hope you'll implement this functionality b/c it's crucial for my project.

Thanks.

@github-actions github-actions bot changed the title esp_http_client: separate buffer_size config option for transmit esp_http_client: separate buffer_size config option for transmit (IDFGH-1226) May 23, 2019
@mahavirj mahavirj requested a review from jitin17 June 24, 2019 13:11
@jitin17
Copy link
Contributor

jitin17 commented Jun 24, 2019

@olegantonyan This feature looks good and has been added for review in our internal work queue. Thanks for your efforts!!

igrr pushed a commit that referenced this pull request Jul 15, 2019
@jitin17
Copy link
Contributor

jitin17 commented Jul 19, 2019

Thanks for your contribution( we did some cosmetic changes), merged to master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants