Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ble/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors (IDFGH-14175) #14975

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nebkat
Copy link
Contributor

@nebkat nebkat commented Dec 4, 2024

Description

If multiple descriptors are defined for a characteristic where there is a mix of 16-bit and 128-bit UUIDs, an error log was printed during the discovery process.

E (27577) BT_GATT: format mismatch

As per BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3, Part F pages 1419/1420:

If sequential attributes have differing UUID sizes, the ATT_FIND_INFORMATION_RSP PDU shall end with the first attribute of the pair even though this may mean that it is not filled with the maximum possible amount of (handle, UUID) pairs. This is because it is not possible to include attributes with differing UUID sizes into a single response packet. In this situation, the client must use another ATT_FIND_INFORMATION_REQ PDU with its starting handle updated to fetch the second attribute of the pair and any further ones in its original request.

In other words, if we start returning 16-bit UUID attributes and we encounter 128-bit (or vice-versa) we should simply return what we have so far, and the client should send a new ATT_FIND_INFORMATION_REQ. There is no need for the error log.

Also, interestingly, the return code is ignored anyway:

reason = gatt_build_find_info_rsp(p_rcb, p_msg, &buf_len, s_hdl, e_hdl);
if (reason == GATT_NO_RESOURCES) {
reason = GATT_SUCCESS;
break;
}

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

github-actions bot commented Dec 4, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello nebkat, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 011de7e

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 4, 2024
@github-actions github-actions bot changed the title fix(bt/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors fix(bt/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors (IDFGH-14175) Dec 4, 2024
@nebkat nebkat force-pushed the patch-3 branch 3 times, most recently from e9abb62 to 7cce143 Compare December 4, 2024 11:27
@nebkat nebkat changed the title fix(bt/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors (IDFGH-14175) fix(ble/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors (IDFGH-14175) Dec 4, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants