fix(ble/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors (IDFGH-14175) #14975
+12
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If multiple descriptors are defined for a characteristic where there is a mix of 16-bit and 128-bit UUIDs, an error log was printed during the discovery process.
As per
BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3, Part F
pages 1419/1420:In other words, if we start returning 16-bit UUID attributes and we encounter 128-bit (or vice-versa) we should simply return what we have so far, and the client should send a new
ATT_FIND_INFORMATION_REQ
. There is no need for the error log.Also, interestingly, the return code is ignored anyway:
esp-idf/components/bt/host/bluedroid/stack/gatt/gatt_sr.c
Lines 1016 to 1020 in 030c995
Checklist
Before submitting a Pull Request, please ensure the following: