Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): Add a I2C Simple example (IDFGH-13408) #14315

Closed

Conversation

vinicius-de-assis
Copy link
Contributor

@vinicius-de-assis vinicius-de-assis commented Aug 6, 2024

This program is a simple example of I2C communication using the new I2C API, similar to older versions of the ESP-IDF. The program is essentially the same as in previous versions, with the main difference being the updated API.

Copy link

github-actions bot commented Aug 6, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello vinicius-de-assis, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against b23c131

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 6, 2024
@github-actions github-actions bot changed the title feat(example): Add a I2C Simple example feat(example): Add a I2C Simple example (IDFGH-13408) Aug 6, 2024
vinicius-de-assis

This comment was marked as off-topic.

@vinicius-de-assis vinicius-de-assis changed the base branch from master to release/v5.4 November 5, 2024 19:07
@vinicius-de-assis vinicius-de-assis changed the base branch from release/v5.4 to master November 5, 2024 19:10
@suda-morris
Copy link
Collaborator

sha=b23c131b6469c597bd109b29d5bde05313a6ea4c

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Nov 28, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Dec 5, 2024
espressif-bot pushed a commit that referenced this pull request Dec 5, 2024
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 2f5fcf2.

@Alvin1Zhang Alvin1Zhang closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants