-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http_server): add 413 Payload Too Large response (IDFGH-12767) #13746
feat(http_server): add 413 Payload Too Large response (IDFGH-12767) #13746
Conversation
While not useful for the HTTP parser itself, this is very useful for memory-limited consumers of the HTTP server API.
👋 Hello mmalecki, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@@ -608,6 +608,9 @@ typedef enum { | |||
*/ | |||
HTTPD_411_LENGTH_REQUIRED, | |||
|
|||
/* Incoming payload is too large */ | |||
HTTPD_413_PAYLOAD_TOO_LARGE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest changing to:
HTTPD_413_CONTENT_TOO_LARGE
same comment at other places too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to change this by all means, but all the other names appear to follow the literal HTTP status code names as defined in spec, so just curious as to the motivation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think by other places, he meant at other changes in this PR. Anyways, we have updated the commit to have that change. The MR is in internal review right now. The commit will be reflected on GitHub once the MR gets merged internally. Thanks for your contribution.
sha=2f8d39b68f729bbb743e912710818d772950c736 |
Merged into master with e40b140 |
While not useful for the HTTP parser itself, this is very useful for memory-limited consumers of the HTTP server API.