Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http_server): add 413 Payload Too Large response (IDFGH-12767) #13746

Closed

Conversation

mmalecki
Copy link
Contributor

@mmalecki mmalecki commented May 5, 2024

While not useful for the HTTP parser itself, this is very useful for memory-limited consumers of the HTTP server API.

While not useful for the HTTP parser itself, this is very useful for
memory-limited consumers of the HTTP server API.
@CLAassistant
Copy link

CLAassistant commented May 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented May 5, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello mmalecki, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 2f8d39b

@espressif-bot espressif-bot added the Status: Opened Issue is new label May 5, 2024
@github-actions github-actions bot changed the title feat(http_server): add 413 Payload Too Large response feat(http_server): add 413 Payload Too Large response (IDFGH-12767) May 5, 2024
@@ -608,6 +608,9 @@ typedef enum {
*/
HTTPD_411_LENGTH_REQUIRED,

/* Incoming payload is too large */
HTTPD_413_PAYLOAD_TOO_LARGE,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing to:

HTTPD_413_CONTENT_TOO_LARGE

same comment at other places too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to change this by all means, but all the other names appear to follow the literal HTTP status code names as defined in spec, so just curious as to the motivation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by other places, he meant at other changes in this PR. Anyways, we have updated the commit to have that change. The MR is in internal review right now. The commit will be reflected on GitHub once the MR gets merged internally. Thanks for your contribution.

@hmalpani
Copy link
Contributor

sha=2f8d39b68f729bbb743e912710818d772950c736

@hmalpani hmalpani added the PR-Sync-Merge Pull request sync as merge commit label May 24, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: In Progress Work is in progress labels May 24, 2024
@hmalpani
Copy link
Contributor

Merged into master with e40b140

@hmalpani hmalpani closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants