-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allocate HTTP header space for async httpd_req_t objects (IDFGH-12445) #13462
Conversation
👋 Hello tmiw, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Some minor comments, otherwise LGTM! |
Thanks for the feedback! I just pushed some changes to address the formatting/naming comments you had. Let me know if you end up seeing anything else. |
@tmiw Can you please squash the commits? |
This resolves bug espressif#13430 by allocating a new copy of resp_hdrs when calling httpd_req_async_handler_begin(), thus preventing invalid access to memory from async tasks.
7a4e591
to
f799e99
Compare
Done. |
sha=f799e9990952847be9d91b2051356fc8f2879676 |
This resolves bug #13430 by allocating a new copy of resp_hdrs when calling httpd_req_async_handler_begin(), thus preventing invalid access to memory from async tasks.