-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use __builtin_unreachable in HAL_ASSERT no-assert mode (IDFGH-12202) #13256
Conversation
otherwise due to esp-idf using -Werror, we can get errors in code which uses HAL_ASSERT if for example the compiler believes that a variable is used uninitialised, or similar.
|
👋 Hello haileys, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
sha=c3b7af6c3def8b0d5014c2389f5838b66705ee11 |
Hey sorry I didn't realise there was a CLA required. Regarding the patch, take it or leave it, but I'm just not that interested in reviewing a legal contract for this |
otherwise due to esp-idf using -Werror, we can get errors in code which uses HAL_ASSERT if for example the compiler believes that a variable is used uninitialised, or similar. Inspired by #13256
This fixes a compile error when building with esp-clang: