-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing include for rom/uart.h (IDFGH-11947) #13025
Missing include for rom/uart.h (IDFGH-11947) #13025
Conversation
Without this include it fails to compile with this error: ``` esp/esp-idf-v5.2/components/esp_rom/include/esp32/rom/uart.h:262:32: error: implicit declaration of function 'UART_STATUS_REG' [-Werror=implicit-function-declaration] 262 | status = READ_PERI_REG(UART_STATUS_REG(uart_no)); ```
👋 Welcome ricardoquesada, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
🔁 You can re-run automatic PR checks by retrying the DangerJS action |
sha=c5251861dfa4e207398db3d22a84fd56d4e6f96b |
Without this include it fails to compile with this error: ``` esp/esp-idf-v5.2/components/esp_rom/include/esp32/rom/uart.h:262:32: error: implicit declaration of function 'UART_STATUS_REG' [-Werror=implicit-function-declaration] 262 | status = READ_PERI_REG(UART_STATUS_REG(uart_no)); ``` Merges #13025
Without this include it fails to compile with this error: ``` esp/esp-idf-v5.2/components/esp_rom/include/esp32/rom/uart.h:262:32: error: implicit declaration of function 'UART_STATUS_REG' [-Werror=implicit-function-declaration] 262 | status = READ_PERI_REG(UART_STATUS_REG(uart_no)); ``` Merges #13025
Without this include it fails to compile with this error: ``` esp/esp-idf-v5.2/components/esp_rom/include/esp32/rom/uart.h:262:32: error: implicit declaration of function 'UART_STATUS_REG' [-Werror=implicit-function-declaration] 262 | status = READ_PERI_REG(UART_STATUS_REG(uart_no)); ``` Merges #13025
Without this include it fails to compile with this error: ``` esp/esp-idf-v5.2/components/esp_rom/include/esp32/rom/uart.h:262:32: error: implicit declaration of function 'UART_STATUS_REG' [-Werror=implicit-function-declaration] 262 | status = READ_PERI_REG(UART_STATUS_REG(uart_no)); ``` Merges espressif#13025
Without this include it fails to compile with this error: