-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32-C2] Correct REG_SPI_BASE(i) (IDFGH-11421) #12559
Conversation
Given these defines (verified against the technical reference guide): ```c++ #define DR_REG_SPI1_BASE 0x60002000 #define DR_REG_SPI0_BASE 0x60003000 #define DR_REG_SPI2_BASE 0x60024000 ``` The existing formula can never match these registers.
👋 Welcome TD-er, thank you for your first contribution to 📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project. Pull request review and merge process you can expectEspressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.
🔁 You can re-run automatic PR checks by retrying the DangerJS action |
The original suggested macro gave compiler errors.
sha=c55df6374df94160c04730869cacb7ec8d8f0308 |
The existing formula can never match these registers. Closes espressif#12559 Closes espressif#12562
The existing formula can never match these registers. Closes espressif#12559 Closes espressif#12562
Given these defines (verified against the technical reference guide):
The existing formula can never match these registers.