Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32-C2] Correct REG_SPI_BASE(i) (IDFGH-11421) #12559

Closed
wants to merge 2 commits into from

Conversation

TD-er
Copy link
Contributor

@TD-er TD-er commented Nov 10, 2023

Given these defines (verified against the technical reference guide):

#define DR_REG_SPI1_BASE                        0x60002000
#define DR_REG_SPI0_BASE                        0x60003000
#define DR_REG_SPI2_BASE                        0x60024000

The existing formula can never match these registers.

Given these defines (verified against the technical reference guide):
```c++
#define DR_REG_SPI1_BASE                        0x60002000
#define DR_REG_SPI0_BASE                        0x60003000
#define DR_REG_SPI2_BASE                        0x60024000
```

The existing formula can never match these registers.
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Nov 10, 2023

Warnings
⚠️

Some issues found for the commit messages in this MR:

  • the commit message [ESP32-C2] Correct REG_SPI_BASE(i) appears to be a temporary or automatically generated message

Please consider updating these commit messages.


👋 Welcome TD-er, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

🔁 You can re-run automatic PR checks by retrying the DangerJS action

Generated by 🚫 dangerJS against c55df63

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 10, 2023
@github-actions github-actions bot changed the title [ESP32-C2] Correct REG_SPI_BASE(i) [ESP32-C2] Correct REG_SPI_BASE(i) (IDFGH-11421) Nov 10, 2023
The original suggested macro gave compiler errors.
@suda-morris
Copy link
Collaborator

sha=c55df6374df94160c04730869cacb7ec8d8f0308

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Nov 13, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Nov 13, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Reviewing Issue is being reviewed labels Nov 20, 2023
movsb pushed a commit to movsb/esp-idf that referenced this pull request Dec 1, 2023
The existing formula can never match these registers.

Closes espressif#12559
Closes espressif#12562
espressif-bot pushed a commit that referenced this pull request Dec 16, 2023
The existing formula can never match these registers.

Closes #12559
Closes #12562
igrr pushed a commit that referenced this pull request Dec 20, 2023
The existing formula can never match these registers.

Closes #12559
Closes #12562
espressif-bot pushed a commit that referenced this pull request Dec 20, 2023
The existing formula can never match these registers.

Closes #12559
Closes #12562
espressif-bot pushed a commit that referenced this pull request Jan 4, 2024
The existing formula can never match these registers.

Closes #12559
Closes #12562
hathach pushed a commit to adafruit/esp-idf that referenced this pull request Mar 27, 2024
The existing formula can never match these registers.

Closes espressif#12559
Closes espressif#12562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants