Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vfs): Fix event_write may not exit critical section (IDFGH-11084) #12258

Closed
wants to merge 2 commits into from

Conversation

udoudou
Copy link
Contributor

@udoudou udoudou commented Sep 15, 2023

The judgment conditions for entering the critical section and exiting the critical section in event_write are inconsistent, and there may be a problem of entering the critical section but not exiting the critical section.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 15, 2023
@github-actions github-actions bot changed the title fix(vfs): Fix event_write may not exit critical section fix(vfs): Fix event_write may not exit critical section (IDFGH-11084) Sep 15, 2023
@sudeep-mohanty sudeep-mohanty self-requested a review September 18, 2023 07:16
@sudeep-mohanty
Copy link
Collaborator

Thanks for the contribution @udoudou. Changes LGTM! I shall pull in this change to our internal repository for further tests. Thanks!

@sudeep-mohanty
Copy link
Collaborator

sha=369b762b6db7df56f51aaa4e3f73b28be206cd3e

@sudeep-mohanty sudeep-mohanty added the PR-Sync-Merge Pull request sync as merge commit label Sep 18, 2023
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Sep 18, 2023
espressif-bot pushed a commit that referenced this pull request Sep 21, 2023
This commit fixes the event_write() function where the critical section
was unbalanced.

Merges #12258
espressif-bot pushed a commit that referenced this pull request Sep 27, 2023
This commit fixes the event_write() function where the critical section
was unbalanced.

Merges #12258
espressif-bot pushed a commit that referenced this pull request Oct 19, 2023
This commit fixes the event_write() function where the critical section
was unbalanced.

Merges #12258
espressif-bot pushed a commit that referenced this pull request Oct 23, 2023
This commit fixes the event_write() function where the critical section
was unbalanced.

Merges #12258
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress labels Dec 1, 2023
movsb pushed a commit to movsb/esp-idf that referenced this pull request Dec 1, 2023
This commit fixes the event_write() function where the critical section
was unbalanced.

Merges espressif#12258
Copy link

github-actions bot commented Dec 9, 2023

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello udoudou, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 5595ab2

@udoudou udoudou closed this Dec 9, 2023
hathach pushed a commit to adafruit/esp-idf that referenced this pull request Mar 27, 2024
This commit fixes the event_write() function where the critical section
was unbalanced.

Merges espressif#12258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants