mbedtls: define MBEDTLS_SSL_CID_TLS1_3_PAD_GRANULARITY for CID padding

[hasheddan]

Updates config to define the new MBEDTLS_SSL_CID_TLS1_3_PAD_GRANULARITY
option, which replaced the previously used
MBEDTLS_SSL_CID_PADDING_GRANULARITY. The old option is continuing to be
used as the new one exceeds the maximum length for an option name in
esp-idf.

See Mbed-TLS/mbedtls#4490 for more information.

Signed-off-by: Daniel Mangum [email protected]

Note: enabling MBEDTLS_SSL_CID_PADDING_GRANULARITY without this fix currently breaks builds.

[hasheddan]

Hmm seeing the following:

MBEDTLS_SSL_CID_TLS1_3_PADDING_GRANULARITY is 42 characters long and it should be 40 at most

Anyway to override so that we can match the underlying mbedtls config?

[laukik-hase]

Hello, @hasheddan!

Thanks for the contribution!

• You would have to shorten the Kconfig option name to 40 characters (e.g. MBEDTLS_SSLCID_TLS13_PADDING_GRANULARITY or MBEDTLS_SSL_CID_TLS1_3_PAD_GRANULARITY). The pre-commit hook does not allow Kconfig option names to be greater than 40 characters.
• Could you also rebase the PR to the latest master branch?

[hasheddan]

You would have to shorten the Kconfig option name to 40 characters

@laukik-hase is there any possibility of overriding the pre-commit hook? I think it would be unfortunate to not mirror the mbedTLS option here.

[hasheddan]

@laukik-hase any updates here? Is shortening the config option an absolute requirement? Would love to get this merged as Connection ID support is currently broken without it.

[igrr]

I'm afraid no, this limit is currently enforced globally and I would prefer not to change it just for this case. Please see if you can shorten the name.

Additionally, since you are renaming a Kconfig option, to ensure compatibility please create components/mbedtls/sdkconfig.rename and add the old and the new option name there (docs, example).

[hasheddan]

@igrr in that case, would it make sense to just keep the previous option and have it select the new one?

[hasheddan]

@igrr I have pushed an update here reflecting the use of the existing option to define the new mbedTLS option

[laukik-hase]

sha=7c63769edefda724ef5c7f7d5e20b33f9e3036ee

[hasheddan]

@igrr @laukik-hase anything else needed here to merge?

[laukik-hase]

@hasheddan, the PR has been merged internally - it will close automatically when it is synced to GitHub.

[laukik-hase]

Merged with a57c8dc, closing this PR!