[Heap Trace Standalone] increase Kconfig max stack depth (IDFGH-10245) #11508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipweinberger
force-pushed
the
user/chip/heap-trace-standalone-stack-size
branch
2 times, most recently
from
6e2faaa to
d1977e7
Compare
chipweinberger
force-pushed
the
user/chip/heap-trace-standalone-stack-size
branch
from
d1977e7 to
bf7020c
Compare
|
Please add this to v5.1 =) |
github-actions
bot
changed the title
|
@ESP-Marius , would be great if you could sync this one as well. I've been testing/using this change without issue. |
|
sha=bf7020c36fcf1d5dc98afb299605ed7be5ac3af2 |
|
LGTM @chipweinberger
I'm afraid 5.1 has already branched of from master and we normally only backport bugfixes. If we allowed features to be backported it would greatly increase the number of changes done to stable branches and increase the regression risk (even though I agree for this change the risk is minimal) 😢 |
espressif-bot
added
Status: Reviewing
|
merged 23cba5f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase max stack depth from 10 -> 32
10 is too small a maximum, and is preventing me from knowing who is calling the function that is leaking.