Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvs_host_test: replace sprintf with snprintf (IDFGH-9781) #11116

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

codysch
Copy link
Contributor

@codysch codysch commented Apr 3, 2023

With some libc impls (ie: Xcode macos sdk 13.1), sprintf is marked as deprecated and causes the build with -Werror to fail. Switch the sprintf usage in test_nvs.cpp to use snprintf to allow builds to complete without warning.

With some libc impls (ie: Xcode 13.1), sprintf is marked as deprecated
and causes the build with `-Werror` to fail. Switch the `sprintf` usage
in test_nvs.cpp to use `snprintf` to allow builds to complete without
warning.
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 3, 2023
@github-actions github-actions bot changed the title nvs_host_test: replace sprintf with snprintf nvs_host_test: replace sprintf with snprintf (IDFGH-9781) Apr 3, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@igrr igrr added the PR-Sync-Merge Pull request sync as merge commit label Apr 12, 2023
@igrr
Copy link
Member

igrr commented Apr 12, 2023

sha=cbe906e53c3c30e608438e374a5c77ca4ca14edc

@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Apr 12, 2023
@espressif-bot espressif-bot merged commit 6da2eb9 into espressif:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants