Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimble: Added Walkthrough tutorial for phy_prph example. (IDFGH-9693) #11034

Closed

Conversation

ESPAbhinav
Copy link
Collaborator

No description provided.

@rahult-github rahult-github self-assigned this Mar 21, 2023
@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 21, 2023
@github-actions github-actions bot changed the title Nimble: Added Walkthrough tutorial for phy_prph example. Nimble: Added Walkthrough tutorial for phy_prph example. (IDFGH-9693) Mar 21, 2023

## Introduction

In this tutorial, the ble_phy peripheral example code for the espressif chipsets with BLE5.0 support is reviewed. This example aims at understanding how to establish connections on preferred PHY and changing LE PHY once the connection is established. The code implements a BLE Peripheral PHY, which establishes a connection on LE 1M PHY and switches to LE 2M PHY/CODED once the connection is established.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This example aims at understanding how to establish connections on preferred PHY and changing LE PHY once the connection is established"

To

"This example aims at understanding how to accept incoming connections on preferred PHY and process the request to change LE PHY once the connection is established"


```

The main function calls `ble_svc_gap_device_name_set()` to set the default device name. 'blecent_phy' is passed as the default device name to this function.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "blecent_phy" to "bleprph-phy"

}
```

To support increased messaging, BLE5.0 is added with extended advertising PDUs. These PDUs are broadcast-only events (like electronic beacons). The following function is used to make extended advertisements. In Bluetooth® 4.0, all advertising was done on 3 of the 40 – 2.4GHz ISM band channels. With Bluetooth 5 there are now two sets of advertising channels: primary and secondary. The primary advertising channels are the original 3 of the 40 advertising channels defined in Bluetooth 4. While the secondary advertising channels use the 37 fixed channels previously reserved for data.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bluetooth 4 --> Bluetooth 4.0


```c

static void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section can be removed. Just keep ext_bleprph_advertise.


To support increased messaging, BLE5.0 is added with extended advertising PDUs. These PDUs are broadcast-only events (like electronic beacons). The following function is used to make extended advertisements. In Bluetooth® 4.0, all advertising was done on 3 of the 40 – 2.4GHz ISM band channels. With Bluetooth 5 there are now two sets of advertising channels: primary and secondary. The primary advertising channels are the original 3 of the 40 advertising channels defined in Bluetooth 4. While the secondary advertising channels use the 37 fixed channels previously reserved for data.


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a line describing, that as s_current_phy value keeps changing , the advertising data also gets modified.

@ESPAbhinav ESPAbhinav force-pushed the feature/Walkthrough_for_prph branch from f014765 to f9a895c Compare March 21, 2023 11:45
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@rahult-github
Copy link
Collaborator

sha=55fd7d43c1995ff2351da51aaaa4f2df6f71de2a

@rahult-github rahult-github added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Mar 24, 2023
@rahult-github
Copy link
Collaborator

sha=f9a895c9a80a83be0e17557b77b1403b47021bd7

@rahult-github rahult-github added the PR-Sync-Merge Pull request sync as merge commit label Mar 24, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Aug 10, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, sorry for very slow turnaround, changes have been merged with 6e1d60e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants