hal/uart_ll.h: Fix compile with C++ (ESP32-S3/H2) (IDFGH-9255) #10640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm including <hal/uart_ll.h> in my C++ application because I need to
bypass the uart driver. The inline functions in the header file fail to
compile as C++.
With xtensa-esp32s2-elf-g++ (crosstool-NG esp-2021r2-patch3) 8.4.0 it
doesn't allow copying the union like this:
hal/uart_ll.h: In function 'uint32_t uart_ll_get_baudrate(uart_dev_t*)':
hal/uart_ll.h:181:37: error: no matching function for call to 'uart_clkdiv_reg_t(volatile uart_clkdiv_reg_t&)'
uart_clkdiv_reg_t div_reg = hw->clkdiv;
^~~~~~
hal/uart_ll.h: In function 'void uart_ll_inverse_signal(uart_dev_t*, uint32_t)':
hal/uart_ll.h:822:38: error: no matching function for call to 'uart_conf0_reg_t(volatile uart_conf0_reg_t&)'
uart_conf0_reg_t conf0_reg = hw->conf0;
^~~~~
There are some instances of incompatibility specific to the ESP32-S3/H2
header files that the previous commit didn't resolve.
github-actions
bot
changed the title
|
sha=f9dc6ca1f58a5eff799b0d7a09cc51fd66475e11 |
suda-morris
added
PR-Sync-Merge
espressif-bot
added
Resolution: NA
espressif-bot
pushed a commit
to espressif/esp-hal-components
that referenced
this pull request
Feb 10, 2023
espressif-bot
pushed a commit
that referenced
this pull request
Feb 11, 2023
|
Thanks for the contribution, this fix was cherry-picked in d78d1a2 |
espressif-bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
espressif-bot
pushed a commit
that referenced
this pull request
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm including
<hal/uart_ll.h>in my C++ application because I need to bypass the uart driver. The inline functions in the header file fail to compile as C++.With xtensa-esp32s2-elf-g++ (crosstool-NG esp-2021r2-patch3) 8.4.0 it doesn't allow copying the union like this:
There are some instances of incompatibility specific to the ESP32-S3/H2 header files that the previous commit didn't resolve.