-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed mismatch in printf types (IDFGH-8883) #10304
Conversation
I believe the |
@KaeLL Updates made 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @gregjesl!
Could you please also remove the following line in the same PR:
target_compile_options(${COMPONENT_LIB} PRIVATE "-Wno-format") |
and combine your changes into a single commit (using
git rebase -i
).
Removed duplicate `l` in format Updated print types Updated CMake
5a16981
to
58d64f9
Compare
@igrr Changes made. I updated a couple other print statements as well, let me know if I over-did it 😄 |
sha=58d64f9a00dea44273004cfecc15f68008571ab3 |
@gregjesl I actually had to revert the changes related to 8- and 16-bit types. This is because newlib-nano (CONFIG_NEWLIB_NANO_FORMAT option) doesn't support 8-bit-specific format specifier produced by PRIu8... (Our internal CI have caught this issue on C2, where CONFIG_NEWLIB_NANO_FORMAT is enabled by default and this example has started failing.) |
Closes #10303