Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libstdc++ in a linker.lf file with a scheme (IDFGH-6414) #8073

Closed
philippe44 opened this issue Dec 13, 2021 · 5 comments
Closed

Use libstdc++ in a linker.lf file with a scheme (IDFGH-6414) #8073

philippe44 opened this issue Dec 13, 2021 · 5 comments
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@philippe44
Copy link

It's a funny problem: I want to move the .bss section of libstdc++ to extram. My linker.lf works with any other library, but it fails with libstdc++ saying there is "illegal nesting". I suspect that the "+" symbol is the culprit but I've tried different escape options and none worked...

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 13, 2021
@github-actions github-actions bot changed the title Use libstdc++ in a linker.lf file with a scheme Use libstdc++ in a linker.lf file with a scheme (IDFGH-6414) Dec 13, 2021
@philippe44
Copy link
Author

philippe44 commented Dec 13, 2021

It's here in fragments.py

class Fragment():
    __metaclass__ = abc.ABCMeta
    """
    Encapsulates a fragment as defined in the generator syntax. Sets values common to all fragment and performs processing
    such as checking the validity of the fragment name and getting the entry values.
    """

    IDENTIFIER = Word(alphas + '_', alphanums + '_')
    ENTITY = Word(alphanums + '.-_$')

    @abc.abstractmethod
    def set_key_value(self, key, parse_results):
        pass

    @abc.abstractmethod
    def get_key_grammars(self):
        pass

replace

    ENTITY = Word(alphanums + '.-_$')

by

    ENTITY = Word(alphanums + '.-_$+')

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Dec 17, 2021
@dobairoland
Copy link
Collaborator

Thank you @philippe44 for the report and suggestion for the fix. We will fix this soon in all affected branches. The fixes will be linked here.

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Dec 17, 2021
@philippe44
Copy link
Author

Thanks!

@igrr igrr reopened this Dec 17, 2021
@philippe44
Copy link
Author

oh ok, I thought you'd prefer me to close that 😄

@igrr
Copy link
Member

igrr commented Dec 17, 2021

No worries! This issue should get closed automatically when the commit with the fix lands on Github.

espressif-bot pushed a commit that referenced this issue Dec 24, 2021
espressif-bot pushed a commit that referenced this issue Dec 27, 2021
dskulina pushed a commit to playable-tech/esp-idf that referenced this issue Feb 4, 2022
dskulina pushed a commit to playable-tech/esp-idf that referenced this issue Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

4 participants