Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ Warnings in https://github.com/espressif/esp-idf/blob/master/examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp (IDFGH-5716) #7435

Closed
franz-ms-muc opened this issue Aug 18, 2021 · 2 comments
Closed

C++ Warnings in https://github.com/espressif/esp-idf/blob/master/examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp (IDFGH-5716) #7435

franz-ms-muc opened this issue Aug 18, 2021 · 2 comments
Assignees
@0xjakob
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@franz-ms-muc
Copy link
Contributor

franz-ms-muc commented Aug 18, 2021 •
edited
Loading

C++ Warnings in https://github.com/espressif/esp-idf/blob/master/examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp

CompTransferNode

should add a

// Empty virtual destructor for proper cleanup

virtual ~CompTransferNode() {}
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 18, 2021
@github-actions github-actions bot changed the title C++ Warnings in https://github.com/espressif/esp-idf/blob/master/examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp C++ Warnings in https://github.com/espressif/esp-idf/blob/master/examples/cxx/experimental/experimental_cpp_component/include/i2c_cxx.hpp (IDFGH-5716) Aug 18, 2021
@0xjakob 0xjakob self-assigned this Oct 9, 2021
@0xjakob
Copy link
Contributor

0xjakob commented Oct 9, 2021 •
edited
Loading

@franz-ms-muc Servus! Thanks for pointing this out and sorry for the long follow-up time!

I'm happy that users are actually trying the new code!

@0xjakob
Copy link
Contributor

0xjakob commented Oct 9, 2021 •
edited
Loading

@franz-ms-muc We've created a patch which will go through our internal CI. As soon as it passes, it will be pushed to github.

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Oct 11, 2021
@igrr igrr closed this as completed in d023036 Oct 12, 2021
espressif-bot pushed a commit that referenced this issue Oct 29, 2021
@0xjakob
[cxx]: Added virtual desctructor in I2C class
50b5ff0 
Closes #7435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xjakob 0xjakob

Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xjakob @espressif-bot @franz-ms-muc