Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bzero is deprecated function (IDFGH-3073) #5095

Closed
petrkr opened this issue Apr 10, 2020 · 3 comments
Closed

bzero is deprecated function (IDFGH-3073) #5095

petrkr opened this issue Apr 10, 2020 · 3 comments
Assignees
@SoucheSouche
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF

Comments

@petrkr
Copy link

petrkr commented Apr 10, 2020

Consider replace bzero by memset as long bzero is deprecated and could lead to compile problems with newer gcc

I already tested it here and it works.
https://github.com/espressif/esp-idf/blob/master/components/heap/heap_caps.c#L409

http://man7.org/linux/man-pages/man3/bzero.3.html
https://www.quora.com/In-C-what-is-the-difference-between-bzero-and-memset
@petrkr petrkr added the Type: Feature Request Feature request for IDF label Apr 10, 2020
@github-actions github-actions bot changed the title bzero is deprecated function bzero is deprecated function (IDFGH-3073) Apr 10, 2020
@igrr
Copy link
Member

igrr commented Apr 20, 2020

Hi @petrkr, newlib (which is the C library we use) currently doesn't mark bzero as deprecated. Which compile issues did you encounter with bzero and newer GCC?

@petrkr
Copy link
Author

petrkr commented Apr 20, 2020

It's only for make you notice about that It can be removed in future versions. That is why I mark it only as "feature request" or something like not important in today. Just keep in mind it could be problem later.

@chrta chrta mentioned this issue Jan 17, 2022
Merged
@espressif-bot espressif-bot added the Status: Selected for Development Issue is selected for development label Aug 22, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Selected for Development Issue is selected for development Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Jan 25, 2023
espressif-bot pushed a commit that referenced this issue Jan 27, 2023
@SoucheSouche
heap: replace usage of bzero() with memset() across the component
fb9a7f3 
See #5095
@zikalino
Copy link
Contributor

Closing as the change was made (referenced in commit above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoucheSouche SoucheSouche

Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally Type: Feature Request Feature request for IDF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@igrr @petrkr @zikalino @SoucheSouche @espressif-bot