Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp_lcd: Buffer allocated in I2C IO is bigger than it needs to be (IDFGH-9674) #11015

Closed
BitsForPeople opened this issue Mar 18, 2023 · 0 comments
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@BitsForPeople
Copy link
Contributor

BitsForPeople commented Mar 18, 2023

#define CMD_HANDLER_BUFFER_SIZE I2C_LINK_RECOMMENDED_SIZE(7) // only 7 operations will be queued in the handler ATTOW

The buffer allocated for the I2C transactions in the I2C IO of the esp_lcd component is sized big enough for 7 transactions; and I count 6 + START + STOP operations worst-case in panel_io_i2c_rx_buffer.
I2C_LINK_RECOMMENDED_SIZE assumes a "transaction" to comprise up to 5 operations, so for the 6+2 operations needed, I2C_LINK_RECOMMENDED_SIZE(2) should be sufficient as buffer size, saving (7-2) * (5 * I2C_INTERNAL_STRUCT_SIZE)=600 bytes of heap.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 18, 2023
@github-actions github-actions bot changed the title esp_lcd: Buffer allocated in I2C IO is bigger than it needs to be esp_lcd: Buffer allocated in I2C IO is bigger than it needs to be (IDFGH-9674) Mar 18, 2023
@espressif-bot espressif-bot assigned L-KAYA and unassigned suda-morris Mar 29, 2023
espressif-bot pushed a commit that referenced this issue May 14, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

4 participants