-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Kconfig checker (IDFGH-9516) #10872
Comments
The script has been moved from the Also one doesn't have to use this directly. If the contribution guide is followed then the check should be part of the automatic pre-commit checks. The documentation clearly has to be updated and the corrections backported. So @tadejg. If you do this part then the checker is run (together with others) when you make a git commit. |
I think the key point here is
so the use case, as i understand, is not to check commits in IDF repo, but to use the same tool to check the commits in a custom IDF-based project. Perhaps we could make the tool available as part of https://github.com/espressif/esp-idf-kconfig package? |
@igrr Sounds like a good idea, the checking of kconfig file portion of the tool would be factored out and |
Answers checklist.
General issue report
Documentation mentions a Kconfig checker script here.
This script appears to have been removed in version v4.3.
Still exists in v4.2: https://github.com/espressif/esp-idf/blob/release/v4.2/tools/check_kconfigs.py
Doesn't exist in v4.3: https://github.com/espressif/esp-idf/blob/release/v4.3/tools/check_kconfigs.py
EDIT: As a workaround, I simply downloaded the script from version v4.2 into
esp-idf/tools/check_kconfigs.py
and ran it in my project usingcheck_kconfigs.py -d .
. Seems to work as expected.The text was updated successfully, but these errors were encountered: