Merge branch 'fix/memory_leaks_identified_by_cppcheck_v3.3' into 'rel…

…ease/v3.3' Fix/memory leaks identified by cppcheck (v3.3) See merge request espressif/esp-idf!14505
espressif · Jul 26, 2021 · f69d7ca · f69d7ca
2 parents b2a9dc2 + 5401610
commit f69d7ca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/components/esp_http_client/lib/http_auth.c b/components/esp_http_client/lib/http_auth.c
@@ -51,6 +51,7 @@ static int md5_printf(char *md, const char *fmt, ...)
     va_start(ap, fmt);
     len = vasprintf((char **)&buf, fmt, ap);
     if (buf == NULL) {
+        va_end(ap);
         return ESP_FAIL;
     }
 

diff --git a/components/esp_http_client/lib/http_header.c b/components/esp_http_client/lib/http_header.c
@@ -161,8 +161,8 @@ int http_header_set_format(http_header_handle_t header, const char *key, const c
     char *buf = NULL;
     va_start(argptr, format);
     len = vasprintf(&buf, format, argptr);
-    HTTP_MEM_CHECK(TAG, buf, return 0);
     va_end(argptr);
+    HTTP_MEM_CHECK(TAG, buf, return 0);
     if (buf == NULL) {
         return 0;
     }