Skip to content

Commit

Permalink
Merge branch 'bugfix/fix_mbedlts_ds_memory_leak' into 'master'
Browse files Browse the repository at this point in the history
esp-tls: Fix memory leak in mbedtls ds peripheral when MBEDTLS_THREADING_C enabled

Closes ESPCS-872

See merge request espressif/esp-idf!20563
  • Loading branch information
mahavirj committed Oct 13, 2022
2 parents 836dc4a + ddbe6aa commit f4773d6
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions components/esp-tls/esp_tls_mbedtls.c
Original file line number Diff line number Diff line change
Expand Up @@ -971,14 +971,17 @@ static esp_err_t esp_mbedtls_init_pk_ctx_for_ds(const void *pki)
esp_ds_get_keylen )) != 0) {
ESP_LOGE(TAG, "Error in mbedtls_pk_setup_rsa_alt, returned -0x%04X", -ret);
mbedtls_print_error_msg(ret);
return ESP_FAIL;
ret = ESP_FAIL;
goto exit;
}
ret = esp_ds_init_data_ctx(((const esp_tls_pki_t*)pki)->esp_ds_data);
if (ret != ESP_OK) {
ESP_LOGE(TAG, "Failed to initialize DS parameters from nvs");
return ESP_FAIL;
goto exit;
}
ESP_LOGD(TAG, "DS peripheral params initialized.");
return ESP_OK;
exit:
mbedtls_rsa_free(&rsakey);
return ret;
}
#endif /* CONFIG_ESP_TLS_USE_DS_PERIPHERAL */

0 comments on commit f4773d6

Please sign in to comment.