Skip to content

Commit

Permalink
Tools: Check venv the same way how it will be used later
Browse files Browse the repository at this point in the history
It is possible that import of venv passes but it still cannot be
started. This can happen with the embedded Python deployed by the
ESP-IDF installer.
  • Loading branch information
dobairoland committed Oct 11, 2022
1 parent ee769ab commit bbc5009
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions tools/idf_tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -1983,9 +1983,7 @@ def action_install_python_env(args): # type: ignore
venv_can_upgrade = False

if not os.path.exists(virtualenv_python):
try:
import venv # noqa: F401

if subprocess.run([sys.executable, '-m', 'venv', '-h'], check=False, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL).returncode == 0:
# venv available
virtualenv_options = ['--clear'] # delete environment if already exists
if sys.version_info[:2] >= (3, 9):
Expand All @@ -1998,7 +1996,7 @@ def action_install_python_env(args): # type: ignore
*virtualenv_options,
idf_python_env_path],
stdout=sys.stdout, stderr=sys.stderr)
except ImportError:
else:
# The embeddable Python for Windows doesn't have the built-in venv module
install_legacy_python_virtualenv(idf_python_env_path)

Expand Down

0 comments on commit bbc5009

Please sign in to comment.