Skip to content

Commit

Permalink
psram: remove CS/CLK pin settings in kconfig on ESP32S2/S3
Browse files Browse the repository at this point in the history
  • Loading branch information
Bruce297 authored and Icarus113 committed Nov 11, 2022
1 parent 3f2f35b commit a674092
Show file tree
Hide file tree
Showing 7 changed files with 31 additions and 37 deletions.
24 changes: 8 additions & 16 deletions components/esp_psram/esp32s2/Kconfig.spiram
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,14 @@ menu "SPI RAM config"
This should only be used for tasks where the stack is never accessed while the cache is disabled.
Cannot be used together with ESP_COREDUMP_ENABLE_TO_FLASH.

menu "PSRAM clock and cs IO for ESP32S2"
depends on SPIRAM
config DEFAULT_PSRAM_CLK_IO
int "PSRAM CLK IO number"
range 0 33
default 30
help
The PSRAM CLOCK IO can be any unused GPIO, user can config it based on hardware design.

config DEFAULT_PSRAM_CS_IO
int "PSRAM CS IO number"
range 0 33
default 26
help
The PSRAM CS IO can be any unused GPIO, user can config it based on hardware design.
endmenu
config SPIRAM_CLK_IO
int
default 30

config SPIRAM_CS_IO
int
default 26

config SPIRAM_FETCH_INSTRUCTIONS
bool "Cache fetch instructions from SPI RAM"
default n
Expand Down
4 changes: 2 additions & 2 deletions components/esp_psram/esp32s2/esp_psram_impl_quad.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ static const char* TAG = "quad_psram";
#define FLASH_CLK_IO SPI_CLK_GPIO_NUM
#define FLASH_CS_IO SPI_CS0_GPIO_NUM
// PSRAM clock and cs IO should be configured based on hardware design.
#define PSRAM_CLK_IO CONFIG_DEFAULT_PSRAM_CLK_IO // Default value is 30
#define PSRAM_CS_IO CONFIG_DEFAULT_PSRAM_CS_IO // Default value is 26
#define PSRAM_CLK_IO SPI_CLK_GPIO_NUM
#define PSRAM_CS_IO SPI_CS1_GPIO_NUM
#define PSRAM_SPIQ_SD0_IO SPI_Q_GPIO_NUM
#define PSRAM_SPID_SD1_IO SPI_D_GPIO_NUM
#define PSRAM_SPIWP_SD3_IO SPI_WP_GPIO_NUM
Expand Down
24 changes: 8 additions & 16 deletions components/esp_psram/esp32s3/Kconfig.spiram
Original file line number Diff line number Diff line change
Expand Up @@ -49,22 +49,14 @@ menu "SPI RAM config"
This should only be used for tasks where the stack is never accessed while the cache is disabled.
Cannot be used together with ESP_COREDUMP_ENABLE_TO_FLASH.

menu "PSRAM Clock and CS IO for ESP32S3"
depends on SPIRAM
config DEFAULT_PSRAM_CLK_IO
int "PSRAM CLK IO number"
range 0 33
default 30
help
The PSRAM Clock IO can be any unused GPIO, please refer to your hardware design.

config DEFAULT_PSRAM_CS_IO
int "PSRAM CS IO number"
range 0 33
default 26
help
The PSRAM CS IO can be any unused GPIO, please refer to your hardware design.
endmenu
config SPIRAM_CLK_IO
int
default 30

config SPIRAM_CS_IO
int
default 26

config SPIRAM_FETCH_INSTRUCTIONS
bool "Cache fetch instructions from SPI RAM"
default n
Expand Down
2 changes: 1 addition & 1 deletion components/esp_psram/esp32s3/esp_psram_impl_octal.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#define OCT_PSRAM_ADDR_BITLEN 32
#define OCT_PSRAM_RD_DUMMY_BITLEN (2*(10-1))
#define OCT_PSRAM_WR_DUMMY_BITLEN (2*(5-1))
#define OCT_PSRAM_CS1_IO CONFIG_DEFAULT_PSRAM_CS_IO
#define OCT_PSRAM_CS1_IO SPI_CS1_GPIO_NUM

#define OCT_PSRAM_CS_SETUP_TIME 3
#define OCT_PSRAM_CS_HOLD_TIME 3
Expand Down
4 changes: 2 additions & 2 deletions components/esp_psram/esp32s3/esp_psram_impl_quad.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ static const char* TAG = "quad_psram";
#define FLASH_CLK_IO SPI_CLK_GPIO_NUM
#define FLASH_CS_IO SPI_CS0_GPIO_NUM
// PSRAM clock and cs IO should be configured based on hardware design.
#define PSRAM_CLK_IO CONFIG_DEFAULT_PSRAM_CLK_IO // Default value is 30
#define PSRAM_CS_IO CONFIG_DEFAULT_PSRAM_CS_IO // Default value is 26
#define PSRAM_CLK_IO SPI_CLK_GPIO_NUM
#define PSRAM_CS_IO SPI_CS1_GPIO_NUM
#define PSRAM_SPIQ_SD0_IO SPI_Q_GPIO_NUM
#define PSRAM_SPID_SD1_IO SPI_D_GPIO_NUM
#define PSRAM_SPIWP_SD3_IO SPI_WP_GPIO_NUM
Expand Down
5 changes: 5 additions & 0 deletions components/esp_psram/sdkconfig.rename.esp32s2
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# sdkconfig replacement configurations for deprecated options formatted as
# CONFIG_DEPRECATED_OPTION CONFIG_NEW_OPTION

CONFIG_DEFAULT_PSRAM_CLK_IO CONFIG_SPIRAM_CLK_IO
CONFIG_DEFAULT_PSRAM_CS_IO CONFIG_SPIRAM_CS_IO
5 changes: 5 additions & 0 deletions components/esp_psram/sdkconfig.rename.esp32s3
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# sdkconfig replacement configurations for deprecated options formatted as
# CONFIG_DEPRECATED_OPTION CONFIG_NEW_OPTION

CONFIG_DEFAULT_PSRAM_CLK_IO CONFIG_SPIRAM_CLK_IO
CONFIG_DEFAULT_PSRAM_CS_IO CONFIG_SPIRAM_CS_IO

0 comments on commit a674092

Please sign in to comment.