Merge branch 'bugfix/mdns_txt_alloc_issue_v4.4' into 'release/v4.4'

mdns: Fix alloc issue if TXT has empty value See merge request espressif/esp-idf!16889
espressif · Jan 21, 2022 · 9f0a6d8 · 9f0a6d8
2 parents 0b46ac1 + b3f913a
commit 9f0a6d8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c
@@ -702,8 +702,8 @@ static uint16_t _mdns_append_txt_record(uint8_t * packet, uint16_t * index, mdns
     char * tmp;
     mdns_txt_linked_item_t * txt = service->txt;
     while (txt) {
-        uint8_t txt_data_len = strlen(txt->key) + txt->value_len + 1;
-        tmp = (char *)malloc(txt_data_len);
+        uint8_t txt_data_len = strlen(txt->key) + txt->value_len + 1 /* + '=' char */;
+        tmp = (char *)malloc(txt_data_len + 1 /* + '\0' term-char in sprintf() */);
         if (tmp) {
             int offset = sprintf(tmp, "%s=", txt->key);
             memcpy(tmp + offset, txt->value, txt->value_len);