Skip to content

Commit

Permalink
change(console): drop the use of open_memstream()
Browse files Browse the repository at this point in the history
the argtable3 provides string based output return, there is no need to go via
stdio structures.

Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Ivan Grokhotkov <[email protected]>
Closes #12507
  • Loading branch information
alonbl authored and igrr committed Mar 28, 2024
1 parent 34f0a0d commit 9370602
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions components/console/commands.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,14 +125,10 @@ esp_err_t esp_console_cmd_register(const esp_console_cmd_t *cmd)
unused = asprintf(&item->hint, " %s", cmd->hint);
} else if (cmd->argtable) {
/* Generate hint based on cmd->argtable */
char *buf = NULL;
size_t buf_size = 0;
FILE *f = open_memstream(&buf, &buf_size);
if (f != NULL) {
arg_print_syntax(f, cmd->argtable, NULL);
fclose(f);
}
item->hint = buf;
arg_dstr_t ds = arg_dstr_create();
arg_print_syntax_ds(ds, cmd->argtable, NULL);
item->hint = strdup(arg_dstr_cstr(ds));
arg_dstr_destroy(ds);
}
item->argtable = cmd->argtable;

Expand Down

0 comments on commit 9370602

Please sign in to comment.