Skip to content

Commit

Permalink
heap: Remove size check in multi_heap.c when registering a new heap
Browse files Browse the repository at this point in the history
The tlsf now checks for size validity when creating a new heap.

The check previously done in multi_heap_register_impl() is no longer
valid since the tlsf_size() is not known at this time (as the metadata
size is linked ot the size of the memory region passed as parameter
when calling tlsf_create_with_pool())

The tlsf_create_with_pool() will return a null pointer if the size
of the memory is not big enough to hold the metadata overhead and
at least a small block.

Update the test according to the changes in TLSF API
  • Loading branch information
SoucheSouche committed Dec 14, 2022
1 parent 47dc520 commit 72e7cbe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/heap/multi_heap.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ size_t multi_heap_get_allocated_size_impl(multi_heap_handle_t heap, void *p)
multi_heap_handle_t multi_heap_register_impl(void *start_ptr, size_t size)
{
assert(start_ptr);
if(size < (tlsf_size(NULL) + tlsf_block_size_min() + sizeof(heap_t))) {
if(size < (sizeof(heap_t))) {
//Region too small to be a heap.
return NULL;
}
Expand Down

0 comments on commit 72e7cbe

Please sign in to comment.