Skip to content

Commit

Permalink
Merge branch 'fix/esp32s3_ununsed_dcache_as_dram' into 'master'
Browse files Browse the repository at this point in the history
esp_hw_support: Update the memory ptr location/property checks to include the unused DCACHE added to DRAM

Closes IDF-7103

See merge request espressif/esp-idf!22904
  • Loading branch information
mahavirj committed Apr 17, 2023
2 parents 90c2786 + 11d5550 commit 6773ad6
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 2 deletions.
9 changes: 9 additions & 0 deletions components/esp_hw_support/esp_memory_utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,15 @@ bool esp_ptr_byte_accessible(const void *p)
#endif
#if CONFIG_SPIRAM
r |= esp_psram_check_ptr_addr(p);
#endif
#if CONFIG_ESP32S3_DATA_CACHE_16KB
/* For ESP32-S3, when the DCACHE size is set to 16 kB, the unused 48 kB is
* added to the heap in 2 blocks of 32 kB (from 0x3FCF0000) and 16 kB
* (from 0x3C000000 (SOC_DROM_LOW) - 0x3C004000).
* Though this memory lies in the external memory vaddr, it is no different
* from the internal RAM in terms of hardware attributes. It is a part of
* the internal RAM when added to the heap and is byte-accessible .*/
r |= (ip >= SOC_DROM_LOW && ip < (SOC_DROM_LOW + 0x4000));
#endif
return r;
}
Expand Down
23 changes: 22 additions & 1 deletion components/esp_hw_support/include/esp_memory_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,17 @@ inline static bool esp_ptr_internal(const void *p) {
* additional check is required */
r |= ((intptr_t)p >= SOC_RTC_DRAM_LOW && (intptr_t)p < SOC_RTC_DRAM_HIGH);
#endif

#if CONFIG_ESP32S3_DATA_CACHE_16KB
/* For ESP32-S3, when the DCACHE size is set to 16 kB, the unused 48 kB is
* added to the heap in 2 blocks of 32 kB (from 0x3FCF0000) and 16 kB
* (from 0x3C000000 (SOC_DROM_LOW) - 0x3C004000).
* Though this memory lies in the external memory vaddr, it is no different
* from the internal RAM in terms of hardware attributes and it is a part of
* the internal RAM when added to the heap.*/
r |= ((intptr_t)p >= SOC_DROM_LOW && (intptr_t)p < (SOC_DROM_LOW + 0x4000));
#endif

return r;
}

Expand All @@ -277,7 +288,17 @@ bool esp_ptr_external_ram(const void *p);
*/
__attribute__((always_inline))
inline static bool esp_ptr_in_drom(const void *p) {
return ((intptr_t)p >= SOC_DROM_LOW && (intptr_t)p < SOC_DROM_HIGH);
uint32_t drom_start_addr = SOC_DROM_LOW;
#if CONFIG_ESP32S3_DATA_CACHE_16KB
/* For ESP32-S3, when the DCACHE size is set to 16 kB, the unused 48 kB is
* added to the heap in 2 blocks of 32 kB (from 0x3FCF0000) and 16 kB
* (from 0x3C000000 (SOC_DROM_LOW) - 0x3C004000).
* The drom_start_addr has to be moved by 0x4000 (16kB) to accomodate
* this addition. */
drom_start_addr += 0x4000;
#endif

return ((intptr_t)p >= drom_start_addr && (intptr_t)p < SOC_DROM_HIGH);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion components/soc/esp32s3/include/soc/soc.h
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
//Region of memory that is internal, as in on the same silicon die as the ESP32 CPUs
//(excluding RTC data region, that's checked separately.) See esp_ptr_internal().
#define SOC_MEM_INTERNAL_LOW 0x3FC88000
#define SOC_MEM_INTERNAL_HIGH 0x403E2000
#define SOC_MEM_INTERNAL_HIGH 0x403E0000

// Start (highest address) of ROM boot stack, only relevant during early boot
#define SOC_ROM_STACK_START 0x3fceb710
Expand Down

0 comments on commit 6773ad6

Please sign in to comment.