Skip to content

Commit

Permalink
fix(esp_wifi): Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kapilkedawat authored and espressif-bot committed Apr 1, 2024
1 parent c5d8acc commit 431a2a7
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
6 changes: 3 additions & 3 deletions components/esp_wifi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -585,9 +585,9 @@ menu "Wi-Fi"
best APs, handling low rssi events etc.

Risk Warning
- Please note that this feature is still experimental and enabling this potentially can
lead to unpredictable scanning, connection and roaming attempts.
We are still working on tuning and optimising this feature to ensure reliable and stable use.
Please note that this feature is still experimental and enabling this potentially can
lead to unpredictable scanning, connection and roaming attempts.
We are still working on tuning and optimising this feature to ensure reliable and stable use.

menu "Configure roaming App"
depends on ESP_WIFI_ENABLE_ROAMING_APP
Expand Down
5 changes: 1 addition & 4 deletions components/esp_wifi/include/esp_wifi_types_generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,7 @@ typedef struct {

typedef struct {
uint16_t ghz_2_channels; /**< Represents 2.4 GHz channels */
uint8_t unii1_channels; /**< UNII-1 channels */
uint8_t unii2_channels; /**< UNII-2 channels */
uint16_t unii2e_channels; /**< UNII-2 Extended channels */
uint8_t unii3_channels; /**< UNII-3 channels */
uint32_t ghz_5_channels; /**< Represents 5 GHz channels */
} wifi_scan_channel_bitmap_t;

/** @brief Parameters for an SSID scan. */
Expand Down
2 changes: 1 addition & 1 deletion components/esp_wifi/lib
Submodule lib updated from 8fde01 to 1b1ab6
2 changes: 2 additions & 0 deletions components/esp_wifi/wifi_apps/roaming_app/src/Kconfig.roaming
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ menu "Roaming triggers"
after each failed attempt to roam. This allows for the station to keep scanning for better AP's after
the Low RSSI threshold is reached in a stepped manner, rather than only attempting to roam the first time
the current AP's RSSI breaches the set RSSI threshold.
Setting 0 here may cause station to be flooded with low rssi events,
therefore that's not recommended to be kept.

config ESP_WIFI_ROAMING_PERIODIC_SCAN_MONITOR
bool "Conduct periodic scans to check if a better AP is available"
Expand Down
2 changes: 1 addition & 1 deletion components/esp_wifi/wifi_apps/roaming_app/src/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Successive roaming attempts by multiple roaming triggers simultaneously could le

**Periodic Neighbor Report Requests:**

Neighbor Report requests are a part of the IEEE 802.11k specification, and hence the intended network would need to support and be setup in a way to support its mechanisms. Periodic neighbor report requests provide vital information about the network and other APs in the vicinity that are candidate APs of the same network. This can be enabled using “Send Periodic Neighbor Report requests for updating the internal list”. he frequency of these requests is controlled by “Time interval between Periodic Neighbor report Requests”. There can also be a RSSI threshold (“Threshold for sending periodic neighbor report requests”) after which you wish to consider sending these requests however this is set by default to 0.
Neighbor Report requests are a part of the IEEE 802.11k specification, and hence the intended network would need to support and be setup in a way to support its mechanisms. Periodic neighbor report requests provide vital information about the network and other APs in the vicinity that are candidate APs of the same network. This can be enabled using “Send Periodic Neighbor Report requests for updating the internal list”. The frequency of these requests is controlled by “Time interval between Periodic Neighbor report Requests”. There can also be a RSSI threshold (“Threshold for sending periodic neighbor report requests”) after which you wish to consider sending these requests however this is set by default to -20.


**Notes :**
Expand Down

0 comments on commit 431a2a7

Please sign in to comment.