Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Apache license to Update Library #9446

Merged
merged 14 commits into from
Apr 2, 2024
Merged

Set Apache license to Update Library #9446

merged 14 commits into from
Apr 2, 2024

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Apr 2, 2024

Description of Change

Changes the Update Library license to Apache, fillowing all the other Espressif source code.

Tests scenarios

N/A

Related links

Internal.

@SuGlider SuGlider self-assigned this Apr 2, 2024
@SuGlider SuGlider added this to the 3.0.0-RC1 milestone Apr 2, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update HttpsOTAUpdate.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HttpsOTAUpdate.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HttpsOTAUpdate.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HttpsOTAUpdate.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HttpsOTAUpdate.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HttpsOTAUpdate.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update HttpsOTAUpdate.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Update.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat: license":
    • summary looks too short
  • the commit message "feat: update license":
    • summary looks too short
  • the commit message "feat: update license":
    • summary looks too short
  • the commit message "feat: update license":
    • summary looks too short
  • the commit message "feat: update license":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 14 commits (simplifying branch history).
⚠️

The source branch "SuGlider-patch-2" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4928cc9

@SuGlider
Copy link
Collaborator Author

SuGlider commented Apr 2, 2024

@me-no-dev - please take a look and let me know if you agree to this change.

Unless required by applicable law or agreed to in writing, this
software is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
CONDITIONS OF ANY KIND, either express or implied.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@me-no-dev - reverted.
HttpsOTAUpdate.cpp/.h are marked as CC0
Update.h/Updater.cpp are marked as Apache-2.0

Is it correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote Updater, not HttpsOTAUpdate, so the user who wrote it, put that license there :)

@me-no-dev me-no-dev merged commit e709b9a into master Apr 2, 2024
39 checks passed
@me-no-dev me-no-dev deleted the SuGlider-patch-2 branch April 2, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants