fix(webserver): Proposal for simplifying webserver file uploads via form POST.

[everslick]

The form parser has been shown to have issues with files ending with "--\r\n". This commit replaces the form parser with the parser from ESP8266, which is simpler and easier to reason about.

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "Proposal for fixing file webserver uploads via form upload.": body's lines must not be longer than 100 characters summary should not end with a period (full stop) summary looks empty type/action looks empty the commit message "Replace _uploadReadByte() in WebServer/Parsing.cpp with ESP8266 implementation.": summary should not end with a period (full stop) summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello everslick, we appreciate your contribution to this project!

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 16f7d34

[everslick]

The _uploadReadByte() method should be also be replaced with this implementation from ESP8266:

int WebServer::_uploadReadByte(WiFiClient& client){
  int res = client.read();

  if (res < 0) {
    while(!client.available() && client.connected())
      delay(2);

    res = client.read();
  }

  return res;
}

[lucasssvaz]

The _uploadReadByte() method should be also be replaced with this implementation from ESP8266:

int WebServer::_uploadReadByte(WiFiClient& client){
  int res = client.read();

  if (res < 0) {
    while(!client.available() && client.connected())
      delay(2);

    res = client.read();
  }

  return res;
}

Could you also add this to this PR ?

[everslick]

Done.

[lucasssvaz]

Thanks, I'll test everything and get back to you

[P-R-O-C-H-Y]

Looks good. Tested with WebServer example "FSBrowser".