Disable Ethernet library if CONFIG_ETH_ENABLED not defined in sdkconfig.h #8595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
me-no-dev
reviewed
Sep 13, 2023
| @@ -18,6 +18,8 @@ | |||
| Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | |||
| */ | |||
|
|
|||
| #ifdef CONFIG_ETH_ENABLED | |||
There was a problem hiding this comment.
you are checking too early if CONFIG_ETH_ENABLED is defined. At this point in the header, nothing is yet included. You need to at least #include "sdkconfig.h" for this to work
me-no-dev
reviewed
Sep 13, 2023
| @@ -21,6 +21,8 @@ | |||
| #ifndef _ETH_H_ | |||
| #define _ETH_H_ | |||
|
|
|||
| #ifdef CONFIG_ETH_ENABLED | |||
Jason2866
added a commit
to Jason2866/arduino-esp32
that referenced
this pull request
Oct 1, 2023
… sdkconfig.h (espressif#8595)" This reverts commit fff900d.
Jason2866
added a commit
to tasmota/arduino-esp32
that referenced
this pull request
Oct 1, 2023
… sdkconfig.h (espressif#8595)" (#266) This reverts commit fff900d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When used in Platform IO in a combined
arduino, espidfplatform setting, and disabling ETH component, the ETH library generates a lot of error messagesTests scenarios
Running previously running firmware that did not use Ethernet, but does use WiFi and BLE
Tested on esp32 pico d4 with Arduino 2.0.9, IDF 4.4.4