Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update partition_table.rst with Variants Folder detail #8531

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Update partition_table.rst with Variants Folder detail #8531

merged 3 commits into from
Aug 29, 2023

Conversation

James-4DSystems
Copy link
Contributor

##Description of Change
Adding missing detail regarding custom Partitions being added under the variants folder, as the tutorial only covers having the csv in your sketch folder, or in the tools/partitions folder.
This information is critical for anyone designing commercial systems who wants to integrate different partitions to those which are standard, as the Sketch folder or tools/partitions are not really valid options in this scenario, as they are specific to a companies hardware / variant.

##Tests scenarios
General testing on this Tutorial information with own boards.
More detail likely could be added for the Tutorial, however this is the core information that was missing and could not be found elsewhere.

##Related links
#8502

Updating Partition Table Partition with information regarding Variants folder
@James-4DSystems
Copy link
Contributor Author

Not a 3rd party board @VojtechBartoska - This is a Tutorial/Documenation update. Wrong tag? Thanks

@mrengineer7777 mrengineer7777 added Type: Documentation Issue pertains to Documentation of Arduino ESP32 and removed Type: 3rd party Boards labels Aug 18, 2023
@James-4DSystems
Copy link
Contributor Author

Any idea why it failed 1 of the checks? Is someone able to suggest a fix please?

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 29, 2023
@me-no-dev me-no-dev merged commit a9794f9 into espressif:master Aug 29, 2023
@James-4DSystems James-4DSystems deleted the Tutorial branch September 1, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants