Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have added support for the DFRobot Romeo ESP32-S3 board. #8195

Merged
merged 7 commits into from
May 31, 2023

Conversation

fary99
Copy link
Contributor

@fary99 fary99 commented May 12, 2023

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.
I have added support for the DFRobot Romeo ESP32-S3 board.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

I have tested my Pull Request on Arduino-esp32 core v2.0.9 withESP32-S3 Board with this scenario

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

P-R-O-C-H-Y
P-R-O-C-H-Y previously approved these changes May 29, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y removed the Resolution: Awaiting response Waiting for response of author label May 29, 2023
@P-R-O-C-H-Y
Copy link
Member

@fary99 The CI Board test fails with error:

  In file included from /home/runner/Arduino/hardware/espressif/esp32/cores/esp32/esp32-hal-gpio.h:29,
                   from /home/runner/Arduino/hardware/espressif/esp32/cores/esp32/esp32-hal.h:83,
                   from /home/runner/Arduino/hardware/espressif/esp32/cores/esp32/Arduino.h:36,
                   from /tmp/arduino/sketches/BBBCBC2F9559872EE54983F29332A0F0/sketch/CIBoardsTest.ino.cpp:1:
  /home/runner/Arduino/hardware/espressif/esp32/variants/dfrobot_romeo_esp32s3/pins_arduino.h:1: error: unterminated #ifndef
   #ifndef Pins_Arduino_h
   
  In file included from /home/runner/Arduino/hardware/espressif/esp32/cores/esp32/Arduino.h:222,
                   from /tmp/arduino/sketches/BBBCBC2F9559872EE54983F29332A0F0/sketch/CIBoardsTest.ino.cpp:1:
  /home/runner/Arduino/hardware/espressif/esp32/variants/dfrobot_romeo_esp32s3/pins_arduino.h:1: error: unterminated #ifndef
   #ifndef Pins_Arduino_h
   
  In file included from /home/runner/Arduino/hardware/espressif/esp32/libraries/SPI/src/SPI.h:25,
                   from /home/runner/work/arduino-esp32/arduino-esp32/libraries/ESP32/examples/CI/CIBoardsTest/CIBoardsTest.ino:2:
  /home/runner/Arduino/hardware/espressif/esp32/variants/dfrobot_romeo_esp32s3/pins_arduino.h:1: error: unterminated #ifndef
   #ifndef Pins_Arduino_h

You missed #endif for GDI_DISPLAY_FPC_INTERFACE part.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Resolution: Awaiting response Waiting for response of author label May 29, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-requested a review May 29, 2023 11:49
@P-R-O-C-H-Y P-R-O-C-H-Y dismissed their stale review May 29, 2023 11:49

Found issue

@P-R-O-C-H-Y P-R-O-C-H-Y removed the Resolution: Awaiting response Waiting for response of author label May 30, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label May 30, 2023
@me-no-dev me-no-dev merged commit c382265 into espressif:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants