-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have added support for the DFRobot Romeo ESP32-S3 board. #8195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
May 12, 2023
P-R-O-C-H-Y
added
Resolution: Awaiting response
Waiting for response of author
Type: 3rd party Boards
labels
May 15, 2023
P-R-O-C-H-Y
previously approved these changes
May 29, 2023
P-R-O-C-H-Y
removed
the
Resolution: Awaiting response
Waiting for response of author
label
May 29, 2023
@fary99 The CI Board test fails with error:
You missed |
P-R-O-C-H-Y
reviewed
May 29, 2023
P-R-O-C-H-Y
added
the
Resolution: Awaiting response
Waiting for response of author
label
May 29, 2023
P-R-O-C-H-Y
removed
the
Resolution: Awaiting response
Waiting for response of author
label
May 30, 2023
P-R-O-C-H-Y
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Please describe your proposed Pull Request and it's impact.
I have added support for the DFRobot Romeo ESP32-S3 board.
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
I have tested my Pull Request on Arduino-esp32 core v2.0.9 withESP32-S3 Board with this scenario
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)