-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overloads to support __FlashStringHelper like ESP8266 has them. #8111
Conversation
External libraries build test
|
External libraries build test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restores previous definitions for F
and FPSTR
in Wstring.h. This should fix breaking changes in other libraries. I'm not sure about the other changes introduced by this PR.
Can you pease split the changes into separate PRs. There seem to be three unrelated changes. |
Oh dear, I partly understand where this request is coming from, but honestly, I don't have time on my hands to do this RIGHT until 2 weekends away from now. And I don't know how much better it will be in two or three steps. Seeing the first attempt, just reverting the macros breaks something else. I honestly have to ask you to review this as is, because the dependencies are just there. Of course it could be attempted to find out which of the changes, macros, libs, could perhaps stand without the other, probably the libs because they ADD wrappers now, but for that exact same reason, why not review this PR as it stands, pleeeeze? I'm sorry the first PR didn't work for some 3rd party libs. |
The reverted macros now just drop the PSTR, becauses it's a dummy on ESP32, and will always be (?): |
Please add this to 2.0.9, it's a high visible show stopper |
External libraries build test
|
External libraries build test
|
Fixes #8108