-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Bee Data Logger board #7997
Conversation
somehow had duplicated the same name across all my boards. the PID's and VID's were correct, but the name was the same for all of them. that is fixed now.
Hi @strid3r21 Can you provide any data-sheet or docs to the board you want to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good and can be merged.
@P-R-O-C-H-Y @atanisoft the wrong board name should be fixed. |
Not quite, it need to be all upper case. |
fixed. is this a new requirement? my other boards ive added before didn't have all upper case names |
There is a PR #7942 about that which will be merged probably soon. I did review of your PR before I got to mentioned PR so thanks @atanisoft for pointing that out. |
Thanks.
Not specifically a new requirement, but there is a pending PR to move all existing boards to upper case since this ends up used as a precompiler definition which typically are always upper case (as are all other ones from this repos) |
good to know! thanks guys! |
added Bee Data Logger board (esp32s3)
testing in 2.0.7 and works as intended.