Use enum for C++ to avoid macro pitfalls in esp32_hal_uart.h #7926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C prepropressor macros are generally considered deprecated in C++, in this particular case, their use for the serial configuration breaks the enum from the EspSoftwareSerial library, release 8.0.0 onward.
This merge request provides the previous macro defines for C language builds, but replaces them functionally identical with a C++ enumeration for C++ builds, which is the default Arduino language anyway.
The ESP8266 Arduino Core uses a C++ enum already.