in BluetoothSerial.setTimeout also set timeout for parent class Stream. #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the BluetoothSerial.setTimeout function the setTimeout function of the parent Class Stream should also be called.
Without this it is not possible to set the timeout used in for example the ReadString function of an instance of BluetoothSerial. The ReadString function is not overwritten and uses the Stream timeout.
The error was discovered because something like the example Code below would just ignore the timeout and wait the default 1000 ms on readString()
MyBluetoothSerial SerialBT; ... SerialBT.setTimeout(5); String temp = SerialBT.readString();