Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heltec_wifi v3 pins #7846

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Update heltec_wifi v3 pins #7846

merged 1 commit into from
Feb 15, 2023

Conversation

platypii
Copy link
Contributor

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

Description of Change

Update heltec_wifi_kit_32_v3 and heltec_wifi_kit_32_v3 pin headers. @smerkadidit noticed that the pins were not correct for V3. This PR fixes that.

This PR copies over changes from the upstream repo:
https://github.com/Heltec-Aaron-Lee/WiFi_Kit_series

Tests scenarios

I have both Heltec boards, and checked that the new pins were correct.

I also read through the pinout diagram, and schematic drawings for these boards to confirm the correct pins.

Related links

Fixes Issue #7737

This will also unblock these boards in platformio:
platformio/platform-espressif32#1018

See this merged PR for additional documentation, including links to DataSheets, Schematics and Reference manuals:
Heltec-Aaron-Lee/WiFi_Kit_series#163

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Feb 15, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards labels Feb 15, 2023
@me-no-dev me-no-dev merged commit 12bd525 into espressif:master Feb 15, 2023
@platypii platypii deleted the heltec_wifi_v3_pins branch February 15, 2023 16:45
@platypii platypii mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@platypii @CLAassistant @P-R-O-C-H-Y @me-no-dev