-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unnecessary DNS query in hostByName and deadlock in ssl_client #7351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
cziter15
changed the title
Fix hostByName to avoid asking DNS when valid IP is passed via hostna…
Fix unnecessary DNS query in hostByName, fix timeout in ssl_client
Oct 15, 2022
Anyway, it looks like handshake_timeout might not be required to be explicitly defined. Maybe handling it all under socket timeout is a good way? |
cziter15
changed the title
Fix unnecessary DNS query in hostByName, fix timeout in ssl_client
Fix unnecessary DNS query in hostByName and deadlock in ssl_client
Oct 29, 2022
me-no-dev
approved these changes
Nov 2, 2022
SuGlider
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR, @cziter15 ! Thanks!
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Pull request to fix problems found when auditing WiFiClientSecure implementation used by ksIotFrameworkLib.
I have few IoT devices running 24/7 with MQTT. Recently added SSL support and identified that unit based on ESP32 is unable to reconnect after losing connection. I've been looking at WiFi code handling in my library, found some bugs, fixing them improved situation a little bit, but still sometimes device was unable to get back online.
After hours of testing by trial-and-error remotely, I have decided to get pcb on my desk and quickly identified few bugs related to WiFiClientSecure.
This PR aims to fix these bugs:
Tests scenarios
Tested on custom board with ESP-WROOM-32 module without PSRAM. Latest master with applied changes. Looks like ESP32 device is getting back online like other ESP8266 based units.
Related links
Closes #7350 #7356