-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated Deneyap boards pin_arduino.h files #7338
Conversation
New Deneyap Family member, wearable development board
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just fix missing new line at the end of the file in variants/deneyapmini/pins_arduino.h and variants/deneyapkartg/pins_arduino.h.
After that will be ready to be merged :)
fixed |
@zeynepdicle Now the new line at the end of file is missing in all pins_arduino.h files you changed. |
Sorry @P-R-O-C-H-Y I don't understand. Which lines is missing ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeynepdicle Add new line at the end of each pins_arduino.h file you edited. It's not a mistake, but only small some formatting standart.
is that true ? @P-R-O-C-H-Y |
Thanks for fixing, will merge asap as CI passes again :) |
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Please describe your proposed Pull Request and it's impact.
Tests scenarios
Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)
Related links
Please provide links to related issue, PRs etc.
(eg. Closes #number of issue)