Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Deneyap boards pin_arduino.h files #7338

Merged
merged 35 commits into from
Nov 7, 2022

Conversation

zeynepdicle
Copy link
Contributor

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

Please provide links to related issue, PRs etc.

(eg. Closes #number of issue)

New Deneyap Family member, wearable development board
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just fix missing new line at the end of the file in variants/deneyapmini/pins_arduino.h and variants/deneyapkartg/pins_arduino.h.
After that will be ready to be merged :)

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 19, 2022
@zeynepdicle
Copy link
Contributor Author

Please just fix missing new line at the end of the file in variants/deneyapmini/pins_arduino.h and variants/deneyapkartg/pins_arduino.h. After that will be ready to be merged :)

fixed

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Nov 2, 2022

@zeynepdicle Now the new line at the end of file is missing in all pins_arduino.h files you changed.
Please fix it.

@zeynepdicle
Copy link
Contributor Author

@zeynepdicle Now the new line at the end of file is missing in all pins_arduino.h files you changed. Please fix it.

Sorry @P-R-O-C-H-Y I don't understand. Which lines is missing ?

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeynepdicle Add new line at the end of each pins_arduino.h file you edited. It's not a mistake, but only small some formatting standart.

variants/deneyapkart/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapkart1A/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapkartg/pins_arduino.h Outdated Show resolved Hide resolved
variants/deneyapmini/pins_arduino.h Outdated Show resolved Hide resolved
@zeynepdicle
Copy link
Contributor Author

is that true ? @P-R-O-C-H-Y

@P-R-O-C-H-Y
Copy link
Member

is that true ? @P-R-O-C-H-Y

Thanks for fixing, will merge asap as CI passes again :)

@P-R-O-C-H-Y P-R-O-C-H-Y merged commit 271cee1 into espressif:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants