Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Added erase flash menu to all boards #7129

Merged
merged 4 commits into from
Aug 16, 2022
Merged

FIX: Added erase flash menu to all boards #7129

merged 4 commits into from
Aug 16, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Aug 15, 2022 •
edited
Loading

Description of Change

As new Erase Flash option to Arduino IDE menu was added in PR #7043 ,if board that didn't have this option added in board.txt an error will occur. This PR fixes that and add the Erase Flash option to all boards.

For future boards to be added, please don't forget to add this new section to boards.txt.

BOARD_DEFINITON.menu.EraseFlash.none=Disabled
BOARD_DEFINITON.menu.EraseFlash.none.upload.erase_cmd=
BOARD_DEFINITON.menu.EraseFlash.all=Enabled
BOARD_DEFINITON.menu.EraseFlash.all.upload.erase_cmd=-e

Tests scenarios

Tested on ESP32 Wrover Kit (all versions) variant.

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 15, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 2.0.5 milestone Aug 15, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Aug 15, 2022
Merged
@PilnyTomas PilnyTomas mentioned this pull request Aug 15, 2022
Closed
1 task
@jbhunt01
Copy link

jbhunt01 commented Aug 16, 2022 •
edited
Loading

Hey guys I am new here but I have the same issue. I added your changes/additions for my board type and it worked. I did have to close the IDE and re-open it to load the boards.txt file. Thank you for your changes.

@P-R-O-C-H-Y P-R-O-C-H-Y merged commit 7bcba17 into master Aug 16, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the boards_erase_flash branch August 16, 2022 07:44
@mazgch
Copy link
Contributor

mazgch commented Sep 20, 2022

Somehow these new options are not present with all boards in 2.0.5 e.g. nora_w10

mazgch added a commit to mazgch/arduino-esp32 that referenced this pull request Sep 20, 2022
@mazgch
add missing menu option
14085c4 
Somehow the fix espressif#7129 was not applied to NORA-W10 probably both changes were happening at around the same time, this PR fixes this.
@mazgch mazgch mentioned this pull request Sep 20, 2022
Merged
P-R-O-C-H-Y added a commit that referenced this pull request Oct 26, 2022
@mazgch @P-R-O-C-H-Y
add missing menu option (#7282)
86577bf 
Somehow the fix #7129 was not applied to NORA-W10 probably both changes were happening at around the same time, this PR fixes this.

Co-authored-by: Jan Procházka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuGlider SuGlider SuGlider approved these changes

@PilnyTomas PilnyTomas PilnyTomas approved these changes

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
None yet
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@P-R-O-C-H-Y @jbhunt01 @mazgch @PilnyTomas @SuGlider