-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boot freeze when trying to init PSRAM on Pico D4 #6434
Fix boot freeze when trying to init PSRAM on Pico D4 #6434
Conversation
@me-no-dev Could you please merge or add to milestone v2.0.3 ? Thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clean. Reason makes perfect sense to me.
Only if you have |
Right. But it any case gpio 16/17 should never be unconfigured on Pico D4. Maybe you prefer to add the test below. Edit: how is psram connected to Pico D4? Using gpio 16/17? |
Oh yes, I over-read it. So I need to change the fix to allow PSRAM on Pico D4 but not unconfigure GPIO 16/17 on Pico D4. Will do a bit later. |
@me-no-dev I changed the proposed patch to allow PSRAM on Pico D4 but not deconfigure GPIO16/17 on Pico D4 if no PSRAM is found. |
@me-no-dev gentle bump. Is the new version ok with you? |
yes! :) Thanks! |
Summary
Fix a boot freeze when trying to initialize PSRAM on Pico D4.
When not setting
CONFIG_SPIRAM_BOOT_INIT
, the code inpsramInit()
probes for PSRAM, and when it does not detect any PSRAM, deconfigures GPIO16/17 except forESP32D2WDQ5
andESP32PICOD2
. The test is missingESP32PICOD4
for which GPIO16/17 are used for Flash and should not be deconfigured.Tasmota uses a single firmware for multiple ESP32 variants, with or without PSRAM. So it's important that the absence of PSRAM on Pico D4 allows for normal boot.
Impact
Allow normal boot on Pico D4 without PSRAM support