Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Core Debug Level option to Tools menu for all boards in boards.txt #6110

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Conversation

gcweeks
Copy link
Contributor

@gcweeks gcweeks commented Jan 7, 2022

Summary

Using an ESP32 board (namely an Olimex Gateway) I ran into an issue in an Ethernet library that could be debugged simply by setting the core debug level. Looking into it, most boards had this option configurable from the Arduino Tools menu, but a few (including mine) were missing that menu for some reason. I've added the menu for my board, but in addition I've added it for all boards in "boards.txt" because I couldn't think of a reason someone with any board wouldn't want this feature, but let me know if there is any reason to the contrary.

I also cleaned up some messy whitespace, sorry if that makes the commit harder to read.

Impact

All boards offered by the Arduino ESP32 library will now provide a "Core Debug Level" option under the Arduino Tools menu that can be set to "None", "Error", "Verbose", etc.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2022

CLA assistant check
All committers have signed the CLA.

@me-no-dev me-no-dev merged commit c6e30e0 into espressif:master Jan 17, 2022
@me-no-dev
Copy link
Member

Thanks @gcweeks :) looks great. Generally board options are left to the people adding them (users or manufacturers alike) It is also possible that the menu did not exist at the point of adding the board, but that is rather rare case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants