Add CI job which tries to build arduino-esp32 as a component #5842
Conversation
igrr
force-pushed
the
feature/idf_component_ci_and_ver_check
branch
2 times, most recently
from
c13f707 to
844a579
Compare
igrr
force-pushed
the
feature/idf_component_ci_and_ver_check
branch
2 times, most recently
from
ae053e7 to
09b2f35
Compare
igrr
force-pushed
the
feature/idf_component_ci_and_ver_check
branch
from
09b2f35 to
1b41380
Compare
igrr
force-pushed
the
feature/idf_component_ci_and_ver_check
branch
from
1b41380 to
b65b956
Compare
| @@ -56,3 +56,30 @@ jobs: | |||
| python-version: '3.x' | |||
| - name: Build Sketches | |||
| run: bash ./.github/scripts/on-push.sh 1 1 #equal and non-zero to trigger PIO | |||
|
|
|||
There was a problem hiding this comment.
This is a good test, but I am not sure if it is necessary to run with each push. In what cases/changes will this fail, but not fail in the sketch tests? Maybe we can limit it to changes on particular files? I also noticed in the logs that Arduino was not actually built. Probably issue with the extra components path.
There was a problem hiding this comment.
Maybe CMakeLists.txt and Kconfig.projbuild are a good option for filter?
There was a problem hiding this comment.
How about running this for master branch only?
There was a problem hiding this comment.
Sure, but still what would be the benefit compared to the lib-builder doing this every 6 hours? Make sure that Arduino will build without any other submodules and default config?
me-no-dev
changed the title
Summary
This PR is related to #5839.
This PR adds an IDF version check to arduino-esp32 component CMakeLists file. IDF version is checked against the range of supported versions. If the version is not supported, an error is reported.
This check can be bypassed by arduino-esp32 developers by setting an environment variable, see comments in the source code.
This PR also adds a CI job which tries to build arduino-esp32 as a component. The CI job currently runs on the latest release/v4.4 branch of IDF via the official Docker image. When new chips or supported versions are added, build matrix can be adjusted.
Impact