-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(matter): General Review - remove while(!serial) ipv6(enable) and fixes some commentaries in the code #10732
feat(matter): General Review - remove while(!serial) ipv6(enable) and fixes some commentaries in the code #10732
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 62 files 62 suites 5m 41s ⏱️ Results for commit 43c419e. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
This is a General Code Review.
while(!Serial) {}
WiFi.enableIPv6(true)
, given that this is already the default"no-change"
commentarylog_e()
messagesTests scenarios
CI Only
Related links
None