Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(matter): General Review - remove while(!serial) ipv6(enable) and fixes some commentaries in the code #10732

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

SuGlider
Copy link
Collaborator

Description of Change

This is a General Code Review.

  • Removes all part that use while(!Serial) {}
  • Removes all references to WiFi.enableIPv6(true), given that this is already the default
  • Fixes all place with "no-change" commentary
  • Fixes some wrong log_e() messages

Tests scenarios

CI Only

Related links

None

@SuGlider SuGlider added the Area: Libraries Issue is related to Library support. label Dec 16, 2024
@SuGlider SuGlider added this to the 3.1.0 milestone Dec 16, 2024
@SuGlider SuGlider self-assigned this Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(matter):replacing code in examples and header files":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.
Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 43c419e

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Test Results

 62 files   62 suites   5m 41s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
154 runs  154 ✅ 0 💤 0 ❌

Results for commit 43c419e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Matter/examples/MatterColorLight----------
Matter/examples/MatterCommissionTest----------
Matter/examples/MatterComposedLights----------
Matter/examples/MatterContactSensor----------
Matter/examples/MatterDimmableLight----------
Matter/examples/MatterEnhancedColorLight----------
Matter/examples/MatterFan----------
Matter/examples/MatterHumiditySensor----------
Matter/examples/MatterMinimum----------
Matter/examples/MatterOccupancySensor----------
Matter/examples/MatterOnOffLight----------
Matter/examples/MatterOnOffPlugin----------
Matter/examples/MatterPressureSensor----------
Matter/examples/MatterSmartButon----------
Matter/examples/MatterTemperatureLight----------
Matter/examples/MatterTemperatureSensor----------
Matter/examples/WiFiProvWithinMatter----------

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Dec 16, 2024
@SuGlider SuGlider removed the Status: Pending Merge Pull Request is ready to be merged label Dec 16, 2024
@SuGlider SuGlider requested a review from me-no-dev December 16, 2024 14:47
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Dec 16, 2024
@me-no-dev me-no-dev merged commit 30e55fc into espressif:release/v3.1.x Dec 16, 2024
73 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

4 participants