fix(bm): Board Manager install will fail on Windows #10533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some Windows installations, Board Manager will fail to install the RC2 core, because it could not find esptool for the given OS.
👋 Hello me-no-dev, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@lucasssvaz if you want to prevent future issues like this, you can test in get.py for Windows if both OS targets are present and fail if not. It will cause the Windows CI to fail. |
Test Results 62 files 62 suites 16m 34s ⏱️ For more details on these failures, see this check. Results for commit 61414cc. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@me-no-dev I think we should do the same with |
lucasssvaz
added
the
Area: Tools & Build System
|
@lucasssvaz can it be proven/tested? |
|
@me-no-dev Just tested and it will only happen if the 32bit version of the arduino IDE is installed (it will also fail to find other tools like openocd). I think the PR is fine as it is. |
lucasssvaz
approved these changes
Oct 28, 2024
SuGlider
approved these changes
Oct 28, 2024
P-R-O-C-H-Y
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Windows installations, Board Manager will fail to install the RC2 core, because it could not find esptool for the given OS.