-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Waveshare ESP32-S3-Touch-LCD-1.85 board #10477
Conversation
Delete old files
Add the Waveshare ESP32-S3-Touch-LCD-1.85 board
Add the Waveshare ESP32-S3-Touch-LCD-1.85 board
Modify the pin definition
👋 Hello Sail-211010, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
If there is anything that needs to be modified, I hope you can mark the wrong place, because I am not very skilled in the first operation。Thank you very much |
@P-R-O-C-H-Y please rebase this to fix the merge conflicts |
Add the Waveshare ESP32-S3-Touch-LCD-1.85 board
Modify the pin definition
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
@Sail-211010 Can you please quickly check if all the changes are correct now? So we can merge. Thanks :) |
Test Results 56 files - 99 56 suites - 99 4m 13s ⏱️ - 1h 43m 2s Results for commit 5a44fbb. ± Comparison against base commit 7849a79. This pull request removes 12 tests.
|
@P-R-O-C-H-Y Yeah, I don't see any other problems at this point(Thank you for your handling) |
Add the Waveshare ESP32-S3-Touch-LCD-1.85 board:
1.Add board information in boards.txt
2.New default parameters in the variants